-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add r-laminr #29719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add r-laminr #29719
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14446186175. Examine the logs at this URL for more detail. |
|
I agree to be a maintainer |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/r-laminr/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15092618888. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-r ready for review |
|
Please add |
|
Done |
|
@conda-forge/r sorry for tagging. It'd be great if this could be merged soon. It's currently blocking me on another project. Thank you 🙏 |
|
Hi @cbrueffer, Just checking in on this PR. All checks have passed, and the recipe follows the guidelines in the documentation. Please let me know if there's anything else needed from my side. I'd really appreciate it if this could be reviewed and merged when you get a chance. Thanks for your time and support! 🙏 Cheers, |
cbrueffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; please add the one comment, then this is good to go.
|
Thank you! I added a comment with a link to the issue. |
|
I'll need to find out how to merge this despite the Windows build failing (recurring issue at the moment because of some rcpp issues); the current system seems to disable the merge button when checks fail. |
|
@cbrueffer checks are green again. This comment provided the solution: conda-forge/ctng-compilers-feedstock#174 (comment) |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).